[SYCL] Fixed-size groups and partitions are renamed to "chunks" #16151
Conversation
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
|
||
| // #endif |
There was a problem hiding this comment.
| // #endif |
|
|
||
| // #ifdef __SYCL_DEVICE_ONLY__ | ||
| //[[__sycl_detail__::__uses_aspects__(sycl::aspect::ext_oneapi_chunk)]] |
There was a problem hiding this comment.
| // #ifdef __SYCL_DEVICE_ONLY__ | |
| //[[__sycl_detail__::__uses_aspects__(sycl::aspect::ext_oneapi_chunk)]] |
There was a problem hiding this comment.
This comment is still actual
| @@ -157,7 +156,7 @@ template <typename T, int N> struct get_elem_type_unqual<vec<T, N>> { | |||
| template <typename VecT, typename OperationLeftT, typename OperationRightT, | |||
| template <typename> class OperationCurrentT, int... Indexes> | |||
| struct get_elem_type_unqual<SwizzleOp<VecT, OperationLeftT, OperationRightT, | |||
| OperationCurrentT, Indexes...>> { | |||
| OperationCurrentT, Indexes...>> { | |||
There was a problem hiding this comment.
Strictly speaking, there should be no unrelated formatting changes, but in this particular case it is more of a nitpicking and can be ignored.
There was a problem hiding this comment.
the formatting task failed until I called clang-format -i per changed file
upd:
not-strictly:
cd ../llvm &&
git diff --cached --name-only --diff-filter=ACM | grep '\.[ch]pp$'|xargs -I{} clang-format -i```There was a problem hiding this comment.
Topic will be resolved with next commit.
The clang-format tool could be used for essential code as Alexei Sachkov has shared
Previously used way is patching only the changed files but not the file regions
export PATH="$(pwd)/build/bin:$PATH"
git diff -U0 --no-color --relative HEAD^ | $(find -name clang-format-diff.py) -p1 -i
|
As @steffenlarsen said in the original #15721, we should change all non-uniform groups at about the same time, so let's keep this one as a draft until other PRs for other non-uniform groups are ready |
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AndreiZibrov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AndreiZibrov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -318,7 +318,7 @@ branches to safely communicate between all work-items executing the same | |||
| control flow. | |||
|
|
|||
| NOTE: This differs from the `fragment` returned by `get_opportunistic_group()` | |||
| because a `tangle_group` requires the implementation to track group membership. | |||
| because a `tangle` requires the implementation to track group membership. | |||
There was a problem hiding this comment.
Feel free to submit this small change as a separate PR, we should be able to merge it almost immediately
| tangle_group<Group>> | ||
| get_tangle_group(Group group) { | ||
| tangle<Group>> | ||
| get_tangle(Group group) { |
There was a problem hiding this comment.
| get_tangle(Group group) { | |
| entangle(Group group) { |
|
|
||
| // #ifdef __SYCL_DEVICE_ONLY__ | ||
| //[[__sycl_detail__::__uses_aspects__(sycl::aspect::ext_oneapi_chunk)]] |
There was a problem hiding this comment.
This comment is still actual
Part 1: fix for #15721 review